Remove OpenStruct references from Jbuilder #567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at #562, I noticed
OpenStruct
never responsesmap
andcount
method.docker run rubylang/all-ruby ./all-ruby -e 'require "ostruct"; p [:map, :count].map {|m| OpenStruct.new({}).respond_to?(m) }'
So, even we remove
OpenStruct
related codes completely, Jbuilder can handle themBut if an OpenStruct instance has both
map
andcount
fields, it would be broken.So, strictly speaking, this change is a breaking change.
What do you think?
If you don't agree with this change, you can just close this PR.
I just want to tell you another possibility.